compose: recreate container when mounted image digest changes by ibrahimypr · Pull Request #13549 · docker/compose

ibrahimypr · 2026-01-23T08:00:53Z

What I did
Until now, mustRecreate logic only checked for divergence in TypeVolume mounts but ignored TypeImage mounts. This inconsistency caused containers to erroneously retain stale images even after the source image was rebuilt.

This commit introduces a new label com.docker.compose.image.mounts that tracks the digests of images used as mounts. The convergence logic is updated to verify this label, ensuring that containers are correctly recreated whenever the underlying image mount digest changes.
Related issue
Fixes #13547

ndeloof

I'm not a fan about using (yet another) labels for this.
As an alternative, I suggest compose could resolve digest for image used as volume source, and update service definition accordingly (comparable to docker compose config --resolve-image-digests). Doing so we get a service definition that can be compared with actual container state.

ibrahimypr · 2026-01-23T18:05:05Z

Thanks for the feedback! I've updated the implementation to resolve the image digest directly in the volume source.
This way, ServiceHash naturally detects the change without needing an extra label.
Updated the tests as well.

ndeloof · 2026-01-26T08:16:38Z

+				}
+				if img, ok := images[imgName]; ok {
+					// Append digest to source so config hash changes when image is rebuilt
+					service.Volumes[i].Source = fmt.Sprintf("%s@%s", vol.Source, img.ID)


better use of reference.ParseDockerRef() then reference.WithDigest() to enforce format follows expectations

ndeloof · 2026-01-26T08:18:06Z

+	"gotest.tools/v3/assert"
+)
+
+func TestMustRecreateImageMounts(t *testing.T) {


we prefer use of e2e test on docker/compose as those allows to detect actual issues with the engine API.

ibrahimypr · 2026-01-26T09:10:53Z

Sorry for the amateur mistakes, this is my first open source contribution!
I've implemented the requested changes: used reference.WithDigest for proper formatting and replaced the unit test with an E2E test case. Thanks for guiding me through it!

ibrahimypr · 2026-01-26T10:14:58Z

Fixed subpath in e2e test fixture (must be relative path) causing daemon error. Also addressed linter feedback.

ndeloof · 2026-01-26T11:59:49Z

 	return nil
 }

+func resolveImageVolumes(service types.ServiceConfig, images map[string]api.ImageSummary, projectName string) {


I wonder this works as expected as you don't pass a *types.ServiceConfig so struct is copied in function scope, leaving original unmodified.

Until now, mustRecreate logic only checked for divergence in TypeVolume mounts but ignored TypeImage mounts. This inconsistency caused containers to erroneously retain stale images even after the source image was rebuilt. This commit updates ensureImagesExists to resolve image volume sources to their digests using the official reference package. This enables ServiceHash (config hash) to naturally detect underlying image digest changes, triggering recreation via the standard convergence logic. An E2E test case is added to verify this behavior. Fixes docker#13547 Signed-off-by: ibrahim yapar <[email protected]>

ibrahimypr · 2026-01-26T14:03:51Z

Thanks again for the review!

Fixed Struct Copy: You were spot on about the struct copy issue—I've updated resolveImageVolumes to accept *types.ServiceConfig so modifications apply correctly.
Local Image & CI: I noticed the E2E tests for local builds were failing with No such image when using the name@digest format (via reference.WithDigest), likely because locally built images in CI don't always have valid repo references. To fix this, I switched to using the Image ID (sha256:...) directly as the volume source. This reliably triggers the ServiceHash change on rebuilds and works for both local and remote images.
Please let me know if this implementation looks good or if you'd prefer a different approach for handling local image references!

codecov · 2026-01-26T14:56:53Z

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pkg/compose/build.go	63.63%	3 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | minor | `v5.0.2` → `v5.1.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v5.1.0`](https://github.com/docker/compose/releases/tag/v5.1.0) [Compare Source](docker/compose@v5.0.2...v5.1.0) #### What's Changed ##### 🐛 Fixes - emit container status events after network reconnection (fixes [#13524](docker/compose#13524)) by [@MaheshThakur9152](https://github.com/MaheshThakur9152) in [#13529](docker/compose#13529) - Fix potential nil pointer dereference in container event monitoring by [@Nepomuk5665](https://github.com/Nepomuk5665) in [#13551](docker/compose#13551) - compose: recreate container when mounted image digest changes by [@ibrahimypr](https://github.com/ibrahimypr) in [#13549](docker/compose#13549) - fix panic by [@ndeloof](https://github.com/ndeloof) in [#13562](docker/compose#13562) - Fix invalid path error when using OCI artifacts on Windows by [@mikesir87](https://github.com/mikesir87) in [#13574](docker/compose#13574) - fix: execute post\_start hooks in docker compose run by [@veeceey](https://github.com/veeceey) in [#13607](docker/compose#13607) - Fix panic when watch rebuilds without up by [@maxproske](https://github.com/maxproske) in [#13610](docker/compose#13610) ##### 🔧 Internal - fsnotify is set in Dockerfile by [@ndeloof](https://github.com/ndeloof) in [#13533](docker/compose#13533) - Dockerfile: update golangci-lint to v2.8.0 by [@thaJeztah](https://github.com/thaJeztah) in [#13535](docker/compose#13535) - replace some uses of strings.Split(N) for strings.Cut by [@thaJeztah](https://github.com/thaJeztah) in [#13542](docker/compose#13542) - Upgrade GitHub Actions to latest versions by [@salmanmkc](https://github.com/salmanmkc) in [#13546](docker/compose#13546) - pkg/compose: remove dependency on github.com/docker/buildx/driver by [@thaJeztah](https://github.com/thaJeztah) in [#13563](docker/compose#13563) - use Docker GitHub Builder to build and sign binaries and bin image by [@crazy-max](https://github.com/crazy-max) in [#13568](docker/compose#13568) - ci: fix bin-image job by [@crazy-max](https://github.com/crazy-max) in [#13569](docker/compose#13569) - pkg/compose: defaultNetworkSettings: refactor by [@thaJeztah](https://github.com/thaJeztah) in [#13580](docker/compose#13580) - pkg/compose: un-export consts by [@thaJeztah](https://github.com/thaJeztah) in [#13584](docker/compose#13584) - modernize some code by [@thaJeztah](https://github.com/thaJeztah) in [#13588](docker/compose#13588) ##### ⚙️ Dependencies - update to go1.25.7 by [@thaJeztah](https://github.com/thaJeztah) in [#13573](docker/compose#13573) - build(deps): bump golang.org/x/sys from 0.40.0 to 0.41.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#13578](docker/compose#13578) - build(deps): bump go.yaml.in/yaml/v4 from 4.0.0-rc.3 to 4.0.0-rc.4 by [@dependabot](https://github.com/dependabot)\[bot] in [#13541](docker/compose#13541) - migrate to moby modules by [@thaJeztah](https://github.com/thaJeztah) in [#13078](docker/compose#13078) #### New Contributors - [@MaheshThakur9152](https://github.com/MaheshThakur9152) made their first contribution in [#13529](docker/compose#13529) - [@salmanmkc](https://github.com/salmanmkc) made their first contribution in [#13546](docker/compose#13546) - [@Nepomuk5665](https://github.com/Nepomuk5665) made their first contribution in [#13551](docker/compose#13551) - [@ibrahimypr](https://github.com/ibrahimypr) made their first contribution in [#13549](docker/compose#13549) - [@veeceey](https://github.com/veeceey) made their first contribution in [#13607](docker/compose#13607) **Full Changelog**: <docker/compose@v5.0.2...v5.1.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

ibrahimypr requested a review from a team as a code owner January 23, 2026 08:00

ibrahimypr requested review from glours and ndeloof January 23, 2026 08:00

ndeloof reviewed Jan 23, 2026

View reviewed changes

ibrahimypr force-pushed the fix/image-mount-recreate branch from 38a9962 to 12e2cd1 Compare January 23, 2026 18:02

ibrahimypr requested a review from ndeloof January 23, 2026 18:06

ndeloof reviewed Jan 26, 2026

View reviewed changes

ibrahimypr force-pushed the fix/image-mount-recreate branch from 12e2cd1 to ac49d00 Compare January 26, 2026 09:09

ibrahimypr requested a review from ndeloof January 26, 2026 09:09

ibrahimypr force-pushed the fix/image-mount-recreate branch from ac49d00 to 193247d Compare January 26, 2026 09:11

ndeloof previously approved these changes Jan 26, 2026

View reviewed changes

ibrahimypr dismissed ndeloof’s stale review via 822f608 January 26, 2026 10:13

ibrahimypr force-pushed the fix/image-mount-recreate branch from 193247d to 822f608 Compare January 26, 2026 10:13

ndeloof reviewed Jan 26, 2026

View reviewed changes

ibrahimypr force-pushed the fix/image-mount-recreate branch from 822f608 to 3463651 Compare January 26, 2026 14:00

ndeloof approved these changes Jan 26, 2026

View reviewed changes

ndeloof enabled auto-merge (rebase) January 26, 2026 14:45

ndeloof merged commit 56ab28a into docker:main Jan 26, 2026
24 checks passed

BrewTestBot mentioned this pull request Feb 24, 2026

docker-compose 5.1.0 Homebrew/homebrew-core#269211

Merged

rancherbot mentioned this pull request Feb 25, 2026

rddepman: bump dockerCompose from 5.0.2 to 5.1.0 rancher-sandbox/rancher-desktop#9931

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

compose: recreate container when mounted image digest changes#13549

compose: recreate container when mounted image digest changes#13549
ndeloof merged 1 commit intodocker:mainfrom
ibrahimypr:fix/image-mount-recreate

ibrahimypr commented Jan 23, 2026

Uh oh!

ndeloof left a comment

Uh oh!

ibrahimypr commented Jan 23, 2026

Uh oh!

ndeloof Jan 26, 2026

Uh oh!

ndeloof Jan 26, 2026

Uh oh!

ibrahimypr commented Jan 26, 2026

Uh oh!

ibrahimypr commented Jan 26, 2026

Uh oh!

ndeloof Jan 26, 2026

Uh oh!

ibrahimypr commented Jan 26, 2026

Uh oh!

Uh oh!

codecov Bot commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ibrahimypr commented Jan 23, 2026

Uh oh!

ndeloof left a comment

Choose a reason for hiding this comment

Uh oh!

ibrahimypr commented Jan 23, 2026

Uh oh!

ndeloof Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

ndeloof Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

ibrahimypr commented Jan 26, 2026

Uh oh!

ibrahimypr commented Jan 26, 2026

Uh oh!

ndeloof Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

ibrahimypr commented Jan 26, 2026

Uh oh!

Uh oh!

codecov Bot commented Jan 26, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants