Introduce schema for compose's configuration file.#1348
Introduce schema for compose's configuration file.#1348draghuram wants to merge 1 commit intodocker:masterfrom draghuram:schema
Conversation
Note that the validation is done after the configuration is converted to Python so the validation should work for any file format. Handles #129. Signed-off-by: Raghuram Devarakonda <[email protected]>
|
related to #129 |
|
thanks for sharing that approach. after a first review, here are some thoughts:
@aanand @bfirsh @dnephin @draghuram i'd appreciate any feedback before i get on it. |
|
Thanks for both your PRs - I'm going to take a proper look at them soon. |
|
This looks like a good start. I don't feel especially strongly about this one vs @funkyfuture's so if you've not got the time, that one will probably win by default. I know @dnephin has advocated for using JSON schema in the past and I can see a hypothetical argument for it (should the Compose format ever become something that's serializable to JSON) but I don't think it's a particularly strong one. |
|
@aanand Thanks for the comments. I agree that we should go with @funkyfuture's PR considering that he is willing to see the feature through. |
|
Handled by #1808 |
I haven't been able to work on this of late so I am creating this PR in the hope that some one else can take it forward.