Support image with ids instead of names#1344
Merged
aanand merged 1 commit intodocker:masterfrom Apr 29, 2015
Merged
Conversation
dnephin
force-pushed
the
fix_pull_with_sha
branch
from
4bc7c3b to
7e1f7a0
Compare
Author
|
@aanand It took me a couple weeks to get to it, but I think this is ready now |
There was a problem hiding this comment.
Is the assert_called_once_with inside this with block ever reached, if create_container raises an APIError?
Author
There was a problem hiding this comment.
Oops, you're right, it needs to be pulled out of the with block.
Signed-off-by: Daniel Nephin <[email protected]>
dnephin
force-pushed
the
fix_pull_with_sha
branch
from
7e1f7a0 to
3dd860f
Compare
Author
|
Fixed the unit test |
|
LGTM |
aanand
added a commit
that referenced
this pull request
Apr 29, 2015
Support image with ids instead of names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #923
Also consolidates the pulls to a single place. Previously the pull triggered by
createwould stream output, but the direct pull would not. Now they will both stream output.Integration test added to cover the failure case.