check buildx version before comparing it#13415
Merged
ndeloof merged 1 commit intodocker:mainfrom Dec 4, 2025
Merged
Conversation
ndeloof
approved these changes
Dec 3, 2025
Contributor
ndeloof
left a comment
ndeloof
left a comment
There was a problem hiding this comment.
LGTM.
any idea about circumstances for buildx plugin to be available but no version can be extracted?
ndeloof
requested changes
Dec 3, 2025
Contributor
ndeloof
left a comment
ndeloof
left a comment
There was a problem hiding this comment.
I had a look at the docker/cli pluginManager code:
Actually, getPlugin may return a plugin instance and err=nil, but plugin.Err gives more details on some missing plugin expectation (typically: failure to get plugin metadata). This Err should be checked as well
Signed-off-by: yangfeiyu <[email protected]>
yangfeiyu20102011
force-pushed
the
main
branch
from
6b13dc2 to
96703b6
Compare
Contributor
Author
|
ndeloof
approved these changes
Dec 4, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Dec 19, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v5.0.0` -> `v5.0.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v5.0.1`](https://github.com/docker/compose/releases/tag/v5.0.1) [Compare Source](docker/compose@v5.0.0...v5.0.1) #### What's Changed ##### 🐛 Fixes - Restored support for `COMPOSE_COMPATIBILITY` by [@​ndeloof](https://github.com/ndeloof) in [#​13424](docker/compose#13424) - Fixed grammatical errors and improve clarity in code. by [@​xiaolinny](https://github.com/xiaolinny) in [#​13429](docker/compose#13429) - Fixed broken `run --quiet`. by [@​ndeloof](https://github.com/ndeloof) in [#​13430](docker/compose#13430) - Fixed SDK example by [@​ndeloof](https://github.com/ndeloof) in [#​13416](docker/compose#13416) - Added a check buildx version is set before comparing it. by [@​yangfeiyu20102011](https://github.com/yangfeiyu20102011) in [#​13415](docker/compose#13415) - Fixed grammar: pluralize 'service' and remove apostrophes in lets. by [@​rashmivagha](https://github.com/rashmivagha) in [#​13423](docker/compose#13423) - Fixed progress UI not restoring terminal once operation completes. by [@​ndeloof](https://github.com/ndeloof) in [#​13439](docker/compose#13439) - Fixed status alignment in progress UI. by [@​ndeloof](https://github.com/ndeloof) in [#​13438](docker/compose#13438) - Restored image layer download progress details on pull. by [@​ndeloof](https://github.com/ndeloof) in [#​13445](docker/compose#13445) - Added 'configured' event at the end of model configuration phase. by [@​glours](https://github.com/glours) in [#​13446](docker/compose#13446) - Introduced a build tag to select watcher implementation. by [@​ndeloof](https://github.com/ndeloof) in [#​13452](docker/compose#13452) - Removed mention for `v2` on README. by [@​alexislefebvre](https://github.com/alexislefebvre) in [#​13451](docker/compose#13451) - Fixed missing error handling in `setEnvWithDotEnv`. by [@​htoyoda18](https://github.com/htoyoda18) in [#​13450](docker/compose#13450) - Adopted morikuni/aec library over raw ANSI sequences. by [@​ndeloof](https://github.com/ndeloof) in [#​13440](docker/compose#13440) - Prevented incorrect progress metrics to break compose display. by [@​ndeloof](https://github.com/ndeloof) in [#​13457](docker/compose#13457) - Restored support for BUILDKIT\_PROGRESS. by [@​ndeloof](https://github.com/ndeloof) in [#​13455](docker/compose#13455) - Added check model plugin is successfully loaded. by [@​ndeloof](https://github.com/ndeloof) in [#​13464](docker/compose#13464) - Added a warning when no service has been selected to build. by [@​ndeloof](https://github.com/ndeloof) in [#​13467](docker/compose#13467) ##### ⚙️ Dependencies - Drop Go min patch version by [@​austinvazquez](https://github.com/austinvazquez) in [#​13418](docker/compose#13418) - bump golang 1.24.11 by [@​austinvazquez](https://github.com/austinvazquez) in [#​13417](docker/compose#13417) - bump osxcross by [@​ndeloof](https://github.com/ndeloof) in [#​13425](docker/compose#13425) - bump golang.org/x/sys from 0.38.0 to 0.39.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​13433](docker/compose#13433) - bump github.com/docker/cli-docs-tool from 0.10.0 to 0.11.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​13437](docker/compose#13437) - bump golang.org/x/sync from 0.18.0 to 0.19.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​13434](docker/compose#13434) - bump tags.cncf.io/container-device-interface from 1.0.1 to 1.1.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​13441](docker/compose#13441) - bump github.com/moby/buildkit from 0.26.2 to 0.26.3 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​13462](docker/compose#13462) #### New Contributors - [@​yangfeiyu20102011](https://github.com/yangfeiyu20102011) made their first contribution in [#​13415](docker/compose#13415) - [@​xiaolinny](https://github.com/xiaolinny) made their first contribution in [#​13429](docker/compose#13429) - [@​alexislefebvre](https://github.com/alexislefebvre) made their first contribution in [#​13451](docker/compose#13451) - [@​htoyoda18](https://github.com/htoyoda18) made their first contribution in [#​13450](docker/compose#13450) **Full Changelog**: <docker/compose@v5.0.0...v5.0.1> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi41OS4xIiwidXBkYXRlZEluVmVyIjoiNDIuNTkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Related issue
#13414
(not mandatory) A picture of a cute animal, if possible in relation to what you did