Gofumpt all the things#12392
Conversation
Format the code with gofumpt to prevent my IDE from reformatting every time I open a file. gofumpt provides a superset of gofmt, so should not impact users that are not using gofumpt. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
b2c4389 to
50f2f54
Compare
glours
left a comment
There was a problem hiding this comment.
LGTM
Open question, should not we add a check of the formatting during the validation step in the CI? 🤔
| - validate-go-mod | ||
| - validate-headers | ||
| - validate-docs | ||
| - validate-fmt |
There was a problem hiding this comment.
FWIW; there's a golangci-lint linter for gofumpt; https://golangci-lint.run/usage/linters/#gofumpt
There was a problem hiding this comment.
nice, makes things even simpler
57b9d9b to
0c7adab
Compare
|
Thanks! I started to add the same logic as we had in docker/cli in the Makefile, which does a "optimistic" try to see if |
0c7adab to
38b61a1
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
38b61a1 to
9aec80b
Compare
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.32.1` -> `v2.32.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.32.2`](https://github.com/docker/compose/releases/tag/v2.32.2) [Compare Source](docker/compose@v2.32.1...v2.32.2) #### What's Changed ##### ✨ Improvements - Add `--pull` to run command by [@​glours](https://github.com/glours) [(12397)](docker/compose#12397) ##### 🐛 Fixes - Only check bind mount conflict if sync action is involved by [@​ndeloof](https://github.com/ndeloof) [(12409)](docker/compose#12409) - When retrying to resolveOrCreateNetwork, retry with a valid network name by [@​gtardif](https://github.com/gtardif) [(12422)](docker/compose#12422) - checkExpectedVolumes must ignore anonymous volumes by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12410 ##### 🔧 Internal - Gofumpt all the things by [@​ndeloof](https://github.com/ndeloof) [(12392)](docker/compose#12392) - Use the 3 latest major versions of the engine to run e2e step by [@​glours](https://github.com/glours) [(12401)](docker/compose#12401) - Replace tibdex/github-app-token by official GitHub create-github-app-token by [@​glours](https://github.com/glours) [(12411)](docker/compose#12411) ##### ⚙️ Dependencies - Bump Golang version to `v1.22.10` and update CI actions by [@​glours](https://github.com/glours) [(12399)](docker/compose#12399) - Bump golang.org/x/net to `v0.33.0` to fix potential security issue by [@​glours](https://github.com/glours) [(12405)](docker/compose#12405) - Bump `compose-go` to `v2.4.7` by [@​glours](https://github.com/glours) [(12438)](docker/compose#12438) **Full Changelog**: docker/compose@v2.32.1...v2.32.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MS40IiwidXBkYXRlZEluVmVyIjoiMzkuOTEuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
same as #12365 + make target