Skip to content

Removes redundant condition from toAPIBuildOptions in build.go#12009

Merged
ndeloof merged 1 commit intodocker:mainfrom
kapurm17:11997-redundant-if
Aug 5, 2024
Merged

Removes redundant condition from toAPIBuildOptions in build.go#12009
ndeloof merged 1 commit intodocker:mainfrom
kapurm17:11997-redundant-if

Conversation

@kapurm17
Copy link
Contributor

What I did
Removed redundant if condition.

Related issue
Fixes #11997

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@kapurm17 kapurm17 force-pushed the 11997-redundant-if branch from 473a402 to 021cd71 Compare July 23, 2024 19:26
@kapurm17 kapurm17 force-pushed the 11997-redundant-if branch from 021cd71 to 13a7a25 Compare July 24, 2024 15:49
@ndeloof ndeloof enabled auto-merge (rebase) August 5, 2024 05:56
@ndeloof ndeloof merged commit 69384a9 into docker:main Aug 5, 2024
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 20, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker/compose](https://github.com/docker/compose) | patch | `v2.29.1` -> `v2.29.2` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>docker/compose (docker/compose)</summary>

### [`v2.29.2`](https://github.com/docker/compose/releases/tag/v2.29.2)

[Compare Source](docker/compose@v2.29.1...v2.29.2)

#### What's Changed

##### ✨ Improvements

-   docs: Update docker compose kill usage [(12041)](docker/compose#12041)
-   add `x-initSync` to watch to always provide initial [(12047)](docker/compose#12047)

##### 🐛 Fixes

-   Removes redundant condition from toAPIBuildOptions in build.go [(12009)](docker/compose#12009)
-   Fix stoping compose process for single container for file change on sync-restart action [(12014)](docker/compose#12014)

##### 🔧  Internal

-   bump golang `1.21.12` [(12017)](docker/compose#12017)
-   bump engine and cli to `v27.1.1`, buildx to `v0.16.1` [(12020)](docker/compose#12020)
-   bump engine and cli to `v27.1.2`, buildx to `v0.16.2`  [(12057)](docker/compose#12057)
-   remove all dependabot update MRs for OTel dependencies [(12006)](docker/compose#12006)
-   bump golang.org/x/sys `v0.22.0` and gofrs/flock `v0.12.1` [(12018)](docker/compose#12018)

#### New Contributors

-   [@&#8203;janbrasna](https://github.com/janbrasna) made their first contribution in [(12041)](docker/compose#12041)
-   [@&#8203;kapurm17](https://github.com/kapurm17) made their first contribution in [(12009)](docker/compose#12009)

**Full Changelog**: docker/compose@v2.29.1...v2.29.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Redundant if condition in the compose/build.go toAPIBuildOptions function

2 participants