Skip to content

add gui/composeview as part of available commands#11851

Merged
glours merged 1 commit intodocker:mainfrom
glours:add-compose-ui-command-tracking
May 23, 2024
Merged

add gui/composeview as part of available commands#11851
glours merged 1 commit intodocker:mainfrom
glours:add-compose-ui-command-tracking

Conversation

@glours
Copy link
Copy Markdown
Contributor

@glours glours commented May 23, 2024

What I did
Add the new open configuration menu to the list of available commands in navmenu metrics

Related issue
N/A

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@glours glours requested review from a team and jhrotko May 23, 2024 16:38
@glours glours self-assigned this May 23, 2024
@glours glours requested review from ndeloof and removed request for a team May 23, 2024 16:38
Comment thread internal/tracing/keyboard_metrics.go Outdated
commandAvailable = append(commandAvailable, "watch")
}

if isDDComposeUI {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency with isDockerDesktopActive I would change it to isDockerDesktopComposeUI

Comment thread internal/tracing/keyboard_metrics.go Outdated
commandAvailable = append(commandAvailable, "watch")
}

if isDDComposeUI {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if isDDComposeUI {
if isDockerDesktopComposeUI {

@glours glours force-pushed the add-compose-ui-command-tracking branch from 88535f2 to 0d6ac18 Compare May 23, 2024 16:54
@glours glours merged commit 2ed40e8 into docker:main May 23, 2024
@glours glours deleted the add-compose-ui-command-tracking branch June 30, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants