Skip to content

fix opentelemetry#11845

Merged
glours merged 1 commit intodocker:mainfrom
ndeloof:fix_otel
May 23, 2024
Merged

fix opentelemetry#11845
glours merged 1 commit intodocker:mainfrom
ndeloof:fix_otel

Conversation

@ndeloof
Copy link
Copy Markdown
Contributor

@ndeloof ndeloof commented May 23, 2024

What I did
Do not capture Tracer in a var as TracerProvider get updated (twice) during the command PreRun

Related issue
https://docker.atlassian.net/browse/COMP-584

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Nicolas De Loof <[email protected]>
@ndeloof ndeloof requested review from a team, glours and jhrotko and removed request for a team May 23, 2024 12:46
Copy link
Copy Markdown
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 7ad73c2 into docker:main May 23, 2024
@ndeloof ndeloof deleted the fix_otel branch May 23, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants