Skip to content

chore(deps): revert "Bump compose-go to v2.0.1"#11647

Merged
jhrotko merged 1 commit intodocker:mainfrom
milas:revert-compose-go-201
Mar 21, 2024
Merged

chore(deps): revert "Bump compose-go to v2.0.1"#11647
jhrotko merged 1 commit intodocker:mainfrom
milas:revert-compose-go-201

Conversation

@milas
Copy link
Copy Markdown
Contributor

@milas milas commented Mar 21, 2024

What I did
compose-go v2.0.1 is causing E2E test failures around dependency semantics.

This reverts commit ad41461 until we can figure that out.

This reverts commit ad41461.

Signed-off-by: Milas Bowman <[email protected]>
@milas milas added the dependencies Pull requests that update a dependency file label Mar 21, 2024
@milas milas requested review from a team, jhrotko and ndeloof March 21, 2024 17:44
@milas milas self-assigned this Mar 21, 2024
@milas milas requested review from glours and removed request for a team March 21, 2024 17:44
Copy link
Copy Markdown
Contributor

@jhrotko jhrotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All test are green now! LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 55.67%. Comparing base (db4ed89) to head (26f687a).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/compose/create.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11647      +/-   ##
==========================================
- Coverage   55.78%   55.67%   -0.12%     
==========================================
  Files         142      142              
  Lines       12241    12241              
==========================================
- Hits         6829     6815      -14     
- Misses       4726     4739      +13     
- Partials      686      687       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhrotko jhrotko merged commit 759d3bc into docker:main Mar 21, 2024
@milas milas deleted the revert-compose-go-201 branch March 21, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants