Skip to content

add support for annotations#11645

Merged
ndeloof merged 1 commit intodocker:mainfrom
ndeloof:annotations
Mar 22, 2024
Merged

add support for annotations#11645
ndeloof merged 1 commit intodocker:mainfrom
ndeloof:annotations

Conversation

@ndeloof
Copy link
Copy Markdown
Contributor

@ndeloof ndeloof commented Mar 21, 2024

What I did

Related issue
closes #11644

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Nicolas De Loof <[email protected]>
@ndeloof ndeloof requested review from a team, glours, jhrotko and milas and removed request for a team March 21, 2024 12:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.61%. Comparing base (db4ed89) to head (2da3e0f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11645      +/-   ##
==========================================
- Coverage   55.78%   55.61%   -0.18%     
==========================================
  Files         142      142              
  Lines       12241    12242       +1     
==========================================
- Hits         6829     6808      -21     
- Misses       4726     4745      +19     
- Partials      686      689       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@jhrotko jhrotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit c5a760c into docker:main Mar 22, 2024
@ndeloof ndeloof deleted the annotations branch March 22, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Compose doesn't pass annotations to the docker

2 participants