feat(experiments): add experimental feature state#11633
Merged
milas merged 2 commits intodocker:mainfrom Mar 20, 2024
Merged
Conversation
milas
requested review from
glours,
jhrotko and
ndeloof
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11633 +/- ##
==========================================
- Coverage 57.72% 57.51% -0.21%
==========================================
Files 138 139 +1
Lines 11736 11784 +48
==========================================
+ Hits 6775 6778 +3
- Misses 4284 4326 +42
- Partials 677 680 +3 ☔ View full report in Codecov by Sentry. |
milas
force-pushed
the
compose-experiments
branch
from
c43eade to
e88a585
Compare
Use environment variable for global opt-out and Docker Desktop (if available) to determine specific experiment states. In the future, we'll allow per-feature opt-in/opt-out via env vars as well, but currently there is a single `COMPOSE_EXPERIMENTAL` env var that can be used to opt-out of all experimental features independently of Docker Desktop configuration. Signed-off-by: Milas Bowman <[email protected]>
milas
force-pushed
the
compose-experiments
branch
from
fb7f42d to
6877c2c
Compare
ndeloof
approved these changes
Mar 20, 2024
Signed-off-by: Milas Bowman <[email protected]>
temenuzhka-thede
pushed a commit
to temenuzhka-thede/compose
that referenced
this pull request
Sep 17, 2024
Use environment variable for global opt-out and Docker Desktop (if available) to determine specific experiment states. In the future, we'll allow per-feature opt-in/opt-out via env vars as well, but currently there is a single `COMPOSE_EXPERIMENTAL` env var that can be used to opt-out of all experimental features independently of Docker Desktop configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Use environment variable for global opt-out and Docker Desktop (if
available) to determine specific experiment states.
In the future, we'll allow per-feature opt-in/opt-out via env vars
as well, but currently there is a single
COMPOSE_EXPERIMENTALenvvar that can be used to opt-out of all experimental features
independently of Docker Desktop configuration.
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did