only use ToModel when --no-interpolate is set#11604
Merged
ndeloof merged 1 commit intodocker:mainfrom Mar 13, 2024
Merged
Conversation
ndeloof
force-pushed
the
config_regressions
branch
from
b871254 to
835b62d
Compare
ndeloof
requested review from
a team,
glours,
jhrotko and
milas
and removed request for
a team
glours
approved these changes
Mar 12, 2024
Contributor
glours
left a comment
glours
left a comment
There was a problem hiding this comment.
LGTM, can you add e2e tests to check both behaviours please?
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
config_regressions
branch
from
835b62d to
db3f61e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11604 +/- ##
==========================================
- Coverage 58.20% 57.73% -0.47%
==========================================
Files 135 138 +3
Lines 11611 11729 +118
==========================================
+ Hits 6758 6772 +14
- Misses 4182 4281 +99
- Partials 671 676 +5 ☔ View full report in Codecov by Sentry. |
This was referenced Mar 13, 2024
|
Hey @ndeloof, great to see a fix. When are you planning to release it? |
Contributor
Author
|
I'll run a release tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
#11556 has impact on
compose configwhich disturbs our users. This PR allows to preserve the previous behavior as long as--no-interpolateisn't set, and only switch to raw model parsing when setWe can then work in parallel to get
ToModelcloser toToProjectuntil we can eventually remove duplicated code pathRelated issue
#11598
(not mandatory) A picture of a cute animal, if possible in relation to what you did