Service name shell completion bugfix#11559
Merged
ndeloof merged 1 commit intodocker:mainfrom Mar 15, 2024
Merged
Conversation
ndeloof
approved these changes
Mar 1, 2024
Contributor
|
for legal reason we require contributors to sign-off commits, please amend your commit and force-push, then we can merge |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11559 +/- ##
==========================================
+ Coverage 57.70% 58.20% +0.49%
==========================================
Files 138 135 -3
Lines 11729 11615 -114
==========================================
- Hits 6768 6760 -8
+ Misses 4283 4183 -100
+ Partials 678 672 -6 ☔ View full report in Codecov by Sentry. |
auto-merge was automatically disabled
March 1, 2024 23:06
Head branch was pushed to by a user without write access
oandrew
force-pushed
the
completion_bugfix
branch
2 times, most recently
from
f7de30e to
3f378ff
Compare
Contributor
Author
|
@ndeloof updated the commit |
glours
approved these changes
Mar 15, 2024
ndeloof
force-pushed
the
completion_bugfix
branch
from
3f378ff to
b43291f
Compare
Signed-off-by: Andrew Onyshchuk <[email protected]>
ndeloof
force-pushed
the
completion_bugfix
branch
from
b43291f to
4f2eb02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix broken shell completion logic for service names.
The bug was introduced in #11251 effectively returning all services regardless of
toCompletevalue.Use a separate variable to only return the matching service names.
Related issue
fixes #11526