Conversation
felixfontein
force-pushed
the
json-progress
branch
2 times, most recently
from
73e9f16 to
3fec17c
Compare
|
I still need to run |
felixfontein
force-pushed
the
json-progress
branch
from
3fec17c to
dea886c
Compare
|
Docs are updated, CI passes (checked in felixfontein#1), but while testing this (now that I was actually able to build this) I noticed that Docker Compose apparently expects Docker Buildx and Docker CLI itself to also have a JSON progress writer. I'm getting |
|
I eventually noticed that in case of errors, the error is always printed regularly and not via the progress API. I added code in d3b85f9 that in case |
felixfontein
force-pushed
the
json-progress
branch
from
d3b85f9 to
15d3343
Compare
|
This is now ready for review. |
felixfontein
force-pushed
the
json-progress
branch
2 times, most recently
from
150e636 to
07a29dd
Compare
|
It probably makes sense to set logging to JSON ( |
cmd/compose/build.go
Outdated
| builderName = os.Getenv("BUILDX_BUILDER") | ||
| } | ||
|
|
||
| // The build backends do not have a "json" progress; use "plain" instead |
There was a problem hiding this comment.
you can use rawjson so buildkit will render raw json solver events and you get a clean json stream for all events
There was a problem hiding this comment.
I created moby/buildkit#4769 since I think it would be better if the rawjson output would write one JSON object per line, instead of using multiple lines to show a more human-readable JSON record (that's not really that human readable anyway).
felixfontein
force-pushed
the
json-progress
branch
from
c5266d4 to
2f78203
Compare
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
felixfontein
force-pushed
the
json-progress
branch
from
2f78203 to
2245943
Compare
|
@ndeloof can you take another look at this? Thanks! |
|
Can you please squash your commits and rebase, I'll enable auto-merge on this PR |
|
@ndeloof thanks a lot for reviewing and merging! Since you rebase-merged I assume I don't need to rebase/squash this anymore :) |
|
auto-merge applied before squash, never mind |
2 participants
What I did
I added a JSON stream progress writer. This allows to write machine readable output to stderr, which makes it a lot easier to use Docker Compose from other tools, like Ansible.
Related issue
Fixes #10872.
(not mandatory) A picture of a cute animal, if possible in relation to what you did
