Fix canonical container name in --dry-run#11425
Merged
ndeloof merged 1 commit intodocker:mainfrom Jan 30, 2024
Merged
Conversation
Signed-off-by: jhrotko <[email protected]>
ndeloof
approved these changes
Jan 30, 2024
laurazard
approved these changes
Jan 30, 2024
Member
laurazard
left a comment
laurazard
left a comment
There was a problem hiding this comment.
✅ LGTM
(and I wonder if we're missing test coverage for --dry-run features since we didn't catch this)
glours
approved these changes
Jan 30, 2024
Contributor
|
the puppies 😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix getCanonicalContainerName to strip the prefix "/". Before, we were removing always the first char (
/) but in--dry-runthis is non-existent. So the fix makes sure we only remove what we intend to.Related issue
fixes #11402
(not mandatory) A picture of a cute animal, if possible in relation to what you did
