Assume /src/pkg/compose/testdata absolute workingdir to make tests reproducible#11212
Merged
ndeloof merged 1 commit intodocker:mainfrom Nov 21, 2023
Merged
Assume /src/pkg/compose/testdata absolute workingdir to make tests reproducible#11212ndeloof merged 1 commit intodocker:mainfrom
ndeloof merged 1 commit intodocker:mainfrom
Conversation
…producible Signed-off-by: Nicolas De Loof <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11212 +/- ##
==========================================
+ Coverage 56.83% 56.86% +0.03%
==========================================
Files 133 133
Lines 11486 11486
==========================================
+ Hits 6528 6532 +4
+ Misses 4321 4318 -3
+ Partials 637 636 -1 ☔ View full report in Codecov by Sentry. |
glours
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests ran inside a container by CI actually have
/srcas root, but when ran on developer's workstation filepath.Abs resolves to a non-portable path, and this makes the assertion fail (https://github.com/docker/compose/blob/main/pkg/compose/ps_test.go#L61).What I did
assume working dir is
/srcfor tests to get a reproducible absolute pathRelated issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did