identify services to build and don't display 'building' if none#11209
Merged
ndeloof merged 1 commit intodocker:mainfrom Nov 21, 2023
Merged
identify services to build and don't display 'building' if none#11209ndeloof merged 1 commit intodocker:mainfrom
ndeloof merged 1 commit intodocker:mainfrom
Conversation
Signed-off-by: Guillaume Lours <[email protected]>
glours
force-pushed
the
hide-building-if-no-service-to-build
branch
from
48171ce to
15b2299
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11209 +/- ##
==========================================
+ Coverage 56.66% 56.80% +0.13%
==========================================
Files 133 133
Lines 11451 11474 +23
==========================================
+ Hits 6489 6518 +29
+ Misses 4326 4321 -5
+ Partials 636 635 -1 ☔ View full report in Codecov by Sentry. |
ndeloof
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
First identify services to be build and early exit if none
Related issue
fixes #11174
(not mandatory) A picture of a cute animal, if possible in relation to what you did
