use official develop section to configure watch command#11026
Merged
milas merged 1 commit intodocker:mainfrom Sep 20, 2023
Merged
use official develop section to configure watch command#11026milas merged 1 commit intodocker:mainfrom
develop section to configure watch command#11026milas merged 1 commit intodocker:mainfrom
Conversation
ndeloof
requested review from
a team,
StefanScherer,
glours,
laurazard,
milas,
nicksieger and
ulyssessouza
and removed request for
a team
Contributor
|
You also need to update |
ndeloof
force-pushed
the
develop
branch
2 times, most recently
from
1cf4d0d to
0cd5d23
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11026 +/- ##
==========================================
- Coverage 57.88% 57.79% -0.09%
==========================================
Files 129 129
Lines 11121 11125 +4
==========================================
- Hits 6437 6430 -7
- Misses 4049 4058 +9
- Partials 635 637 +2
☔ View full report in Codecov by Sentry. |
Signed-off-by: Nicolas De Loof <[email protected]>
milas
approved these changes
Sep 20, 2023
Contributor
milas
left a comment
milas
left a comment
There was a problem hiding this comment.
LGTM! Also tested with include + watch and it works as expected now 🙌🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
use compose-spec/compose-go#461 to configure watch command with
develop`` user is warned about deprecatedx-develop` field. A future Docker Compose release will drop support for thisRelated issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did
https://docker.atlassian.net/browse/ENV-315