remove --timeout=0 flag to cleanup function of watch e2e test#11023
Merged
glours merged 1 commit intodocker:mainfrom Sep 20, 2023
Merged
remove --timeout=0 flag to cleanup function of watch e2e test#11023glours merged 1 commit intodocker:mainfrom
glours merged 1 commit intodocker:mainfrom
Conversation
glours
force-pushed
the
fix-watch-e2e-test-cleanup
branch
from
7b58f6d to
e00fdd9
Compare
ndeloof
approved these changes
Sep 20, 2023
compose down command need the watch process to be killed to succeed Signed-off-by: Guillaume Lours <[email protected]>
glours
force-pushed
the
fix-watch-e2e-test-cleanup
branch
from
e00fdd9 to
61c8be1
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #11023 +/- ##
==========================================
+ Coverage 57.38% 57.98% +0.59%
==========================================
Files 129 129
Lines 11227 11121 -106
==========================================
+ Hits 6443 6448 +5
+ Misses 4151 4040 -111
Partials 633 633 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compose down command need the watch process to be killed to succeed
What I did
Fix the watch e2e tests which fails during the cleanup stage
Related issue
https://github.com/docker/compose/actions/runs/6240098754/job/16939441138
(not mandatory) A picture of a cute animal, if possible in relation to what you did
