implement publish#11008
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #11008 +/- ##
==========================================
- Coverage 57.93% 57.40% -0.53%
==========================================
Files 129 129
Lines 11121 11223 +102
==========================================
Hits 6443 6443
- Misses 4044 4146 +102
Partials 634 634
☔ View full report in Codecov by Sentry. |
milas
left a comment
milas
left a comment
There was a problem hiding this comment.
LGTM, I bikeshed all the names but they also seem fine as-is.
One thing worth mentioning is that OCI projects won't work (with include) if they have external file dependencies like <svc>.build or <svc>.env_file, since it'll look in the temp/cache download directory when trying to load. I don't think that needs to block this, though
| Digest: digest.FromString(string(f)), | ||
| Size: int64(len(f)), | ||
| Annotations: map[string]string{ | ||
| "com.docker.compose": api.ComposeVersion, |
There was a problem hiding this comment.
com.docker.compose.version perhaps?
| }) | ||
| layer := v1.Descriptor{ | ||
| MediaType: v1.MediaTypeImageLayer, | ||
| Digest: digest.FromString(string(f)), |
There was a problem hiding this comment.
| Digest: digest.FromString(string(f)), | |
| Digest: digest.FromBytes(f), |
Internally, digest.FromString will just convert back to bytes so might as well pass it directly
| Annotations: map[string]string{ | ||
| "com.docker.compose": api.ComposeVersion, | ||
| }, | ||
| ArtifactType: "application/vnd.docker.compose.file", |
There was a problem hiding this comment.
I wonder if this should have a +yaml
| Annotations: map[string]string{ | ||
| "com.docker.compose": api.ComposeVersion, | ||
| }, | ||
| ArtifactType: "application/vnd.docker.compose", |
ndeloof
force-pushed
the
oci-publish
branch
2 times, most recently
from
07aa128 to
ead0ce4
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
oci-publish
branch
from
ead0ce4 to
9b2675d
Compare
|
also adopted |
ndeloof
requested review from
a team,
StefanScherer,
laurazard,
nicksieger and
ulyssessouza
and removed request for
a team
3 participants
What I did
implement
publishcommand, to publish compose.yaml files as pseudo-image "layers" with a custom artifact type