Skip to content

ci: tweak restricted imports in linter#10992

Merged
milas merged 2 commits intodocker:mainfrom
milas:linter-imports
Sep 11, 2023
Merged

ci: tweak restricted imports in linter#10992
milas merged 2 commits intodocker:mainfrom
milas:linter-imports

Conversation

@milas
Copy link
Copy Markdown
Contributor

@milas milas commented Sep 11, 2023

What I did

  • Eliminate direct dependency on gopkg.in/yaml.v2
  • Add gopkg.in/yaml.v2 as a restricted import
  • Add github.com/distribution/distribution as a restricted dependency in favor of distribution/reference which is the subset of functionality that Compose needs
  • Remove an unused exclusion

Related issue
n/a

(not mandatory) A picture of a cute animal, if possible in relation to what you did
a small lizard

@milas milas added kind/cleanup dependencies Pull requests that update a dependency file labels Sep 11, 2023
@milas milas requested review from glours and ndeloof September 11, 2023 15:07
@milas milas self-assigned this Sep 11, 2023
glours
glours approved these changes Sep 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@milas
Copy link
Copy Markdown
Contributor Author

milas commented Sep 11, 2023

FYI this does change the compose config output slightly without altering semantics:

  • YAML indentation is slightly different for lists (this is a v2 / v3` thing 🤷🏻)
  • JSON is now "minified" instead of pretty-printed -- I think this generally desirable and more consistent with other JSON command outputs

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (1311546) 57.72% compared to head (4c33b8f) 57.72%.
Report is 1 commits behind head on main.

❗ Current head 4c33b8f differs from pull request most recent head 8e7f853. Consider uploading reports for the commit 8e7f853 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10992   +/-   ##
=======================================
  Coverage   57.72%   57.72%           
=======================================
  Files         127      127           
  Lines       11092    11092           
=======================================
  Hits         6403     6403           
  Misses       4058     4058           
  Partials      631      631
Files Changed Coverage Δ
pkg/compose/compose.go 61.32% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milas milas enabled auto-merge (squash) September 11, 2023 15:41
@milas milas merged commit 19bbb12 into docker:main Sep 11, 2023
@dnhn dnhn mentioned this pull request Sep 21, 2023
Merged
@chenrui333 chenrui333 mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndeloof ndeloof ndeloof approved these changes

@glours glours glours approved these changes

Assignees

@milas milas

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@milas @ndeloof @glours