cli: fix --build flag for create#10982
Merged
milas merged 1 commit intodocker:mainfrom Sep 8, 2023
Merged
Conversation
I missed this during a refactor and there wasn't test coverage. Instead of adding more heavy-weight integration tests, I tried to use `gomock` here to assert on the options objects after CLI flag parsing. I think with a few more helpers, this could be a good way to get a lot more combinations covered without adding a ton of slow E2E tests. Signed-off-by: Milas Bowman <[email protected]>
milas
requested review from
StefanScherer,
glours,
laurazard,
ndeloof,
nicksieger and
ulyssessouza
and removed request for
a team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #10982 +/- ##
==========================================
+ Coverage 57.64% 57.69% +0.04%
==========================================
Files 127 127
Lines 11077 11092 +15
==========================================
+ Hits 6385 6399 +14
- Misses 4060 4061 +1
Partials 632 632
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I missed this during a refactor and there wasn't test coverage. Instead of adding more heavy-weight integration tests, I tried to use
gomockhere to assert on the options objects after CLI flag parsing. I think with a few more helpers, this could be a good way to get a lot more combinations covered without adding a ton of slow E2E tests.Related issue
Introduced here:
(not mandatory) A picture of a cute animal, if possible in relation to what you did
