Enable service explicitly requested to be restarted#10952
Merged
ndeloof merged 1 commit intodocker:mainfrom Sep 1, 2023
Merged
Enable service explicitly requested to be restarted#10952ndeloof merged 1 commit intodocker:mainfrom
ndeloof merged 1 commit intodocker:mainfrom
Conversation
ndeloof
requested review from
a team,
StefanScherer,
glours,
laurazard,
milas,
nicksieger and
ulyssessouza
and removed request for
a team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #10952 +/- ##
==========================================
- Coverage 58.31% 58.25% -0.06%
==========================================
Files 124 124
Lines 10906 10912 +6
==========================================
- Hits 6360 6357 -3
- Misses 3918 3925 +7
- Partials 628 630 +2
☔ View full report in Codecov by Sentry. |
milas
approved these changes
Aug 31, 2023
Contributor
milas
left a comment
milas
left a comment
There was a problem hiding this comment.
LGTM - would be nice to update restart e2e test to cover this 😉
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
restart_with_profile
branch
from
7f4f28e to
ebb20fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
loading local compose.yaml file, if service(s) are explicitly set by command args, automagically enable profiles
also moved "no deps" logic to backend code otherwise running without a project cause a nil pointer panic.
Related issue
fixes #10948
(not mandatory) A picture of a cute animal, if possible in relation to what you did