container logs not sent line by line is broken#10925
Merged
milas merged 2 commits intodocker:mainfrom Aug 23, 2023
Merged
Conversation
…t EOL" This reverts commit 1d15914. Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #10925 +/- ##
==========================================
- Coverage 58.22% 58.20% -0.02%
==========================================
Files 121 121
Lines 10693 10689 -4
==========================================
- Hits 6226 6222 -4
+ Misses 3856 3854 -2
- Partials 611 613 +2
☔ View full report in Codecov by Sentry. |
ndeloof
requested review from
a team,
StefanScherer,
glours,
laurazard,
milas,
nicksieger and
ulyssessouza
and removed request for
a team
milas
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we can't assume we receive container logs line by line. Some framework won't buffer output and will send char by char, and we also can receive looong lines which get buffered to 32kb and then cut into multiple logs.
This assumes we will catch container streams being closed before we receive a
dieevent for container, which could be subject to race condition, but at least the impact here is minimal and the fix works for reproduction examples provided in linked issues.Related issue
fixes #10917
fixes #10658
https://docker.atlassian.net/browse/ENV-246
(not mandatory) A picture of a cute animal, if possible in relation to what you did