Skip to content

upgrade Golang to 1.21#10890

Merged
glours merged 1 commit into
docker:mainfrom
glours:bump-golang-1.21
Aug 10, 2023
Merged

upgrade Golang to 1.21#10890
glours merged 1 commit into
docker:mainfrom
glours:bump-golang-1.21

Conversation

@glours

@glours glours commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

What I did
Bump Golang to version 1.21

Related issue
N/A

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@glours glours self-assigned this Aug 10, 2023
@glours
glours requested review from milas and ndeloof August 10, 2023 12:43
Comment thread Dockerfile Outdated
Signed-off-by: Guillaume Lours <[email protected]>
@glours
glours merged commit 0baf24a into docker:main Aug 10, 2023
@cpuguy83

Copy link
Copy Markdown
Contributor

Why?
Please add reasons why this is changed not just that it's changed, that's plain to see from the code that there's a change.

@ndeloof

ndeloof commented Sep 28, 2023

Copy link
Copy Markdown
Contributor

@cpuguy83 why would we want to keep an older version ?

@cpuguy83

Copy link
Copy Markdown
Contributor

Bumping the go.mod means everyone who compiles it has to bump the go version.
What would you not support a still in-support go version?

Anyway, the point is not to say "you shouldn't have done this" but "what's the reason for the decision?".

@ndeloof

ndeloof commented Sep 28, 2023

Copy link
Copy Markdown
Contributor

everyone who compiles it has to bump the go version

obviously! But if you exclude a few Linux distribution maintainers who have to compile on their own, the many others just consume Docker Compose as a pre-built binary and aren't affected.

what's the reason for the decision?

because we want to rely on latest available and can benefits potential optimizations or new constructs it offers. We don't wait to see a coding opportunity to bump version.

@glours
glours deleted the bump-golang-1.21 branch June 30, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants