Improve shell completion for --project-directory#10879
Merged
Merged
Conversation
Signed-off-by: Ariel Bachar <[email protected]> Signed-off-by: relrelb <[email protected]>
relrelb
force-pushed
the
project_directory_completion
branch
from
August 3, 2023 20:42
f3c50c8 to
8a4095b
Compare
milas
requested review from
a team,
StefanScherer,
glours,
laurazard,
milas,
ndeloof,
nicksieger and
ulyssessouza
and removed request for
a team
August 10, 2023 12:59
glours
approved these changes
Aug 10, 2023
glours
left a comment
glours
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the contribution
glours
enabled auto-merge
August 10, 2023 13:02
ndeloof
approved these changes
Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
docker compose --project-directory <tab>completes file names as well even though this option is invalid.Restrict
--project-directorycompletion to offer directory names only.