Skip to content

Add shell completion for --profile#10878

Merged
glours merged 1 commit into
docker:mainfrom
relrelb:profiles_completion
Aug 10, 2023
Merged

Add shell completion for --profile#10878
glours merged 1 commit into
docker:mainfrom
relrelb:profiles_completion

Conversation

@relrelb

@relrelb relrelb commented Aug 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Basically re-do #8061 for v2.

Tested locally using:

go run ./cmd/main.go __completeNoDesc --profile ''

And the following docker-compose.yml:

version: '3.8'
services:
  frontend:
    image: frontend
    profiles: ["frontend", "gui"]
  phpmyadmin:
    image: phpmyadmin
    depends_on:
      - db
    profiles:
      - debug
  backend:
    image: backend
  db:
    image: mysql

Got the following output:

debug
frontend
gui
:4
Completion ended with directive: ShellCompDirectiveNoFileComp

@relrelb
Add shell completion for --profile
0345461 
Signed-off-by: Ariel Bachar <[email protected]>
Signed-off-by: relrelb <[email protected]>
@relrelb
relrelb force-pushed the profiles_completion branch 3 times, most recently from 7526727 to 0345461 Compare August 3, 2023 20:11
@milas milas self-assigned this Aug 10, 2023
@milas
milas requested review from a team, StefanScherer, glours, laurazard, milas, ndeloof, nicksieger and ulyssessouza and removed request for a team August 10, 2023 13:00
milas
milas approved these changes Aug 10, 2023
View reviewed changes

@milas milas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

glours
glours approved these changes Aug 10, 2023
View reviewed changes

@glours glours left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours
glours enabled auto-merge August 10, 2023 13:04
@glours
glours merged commit 0511b0c into docker:main Aug 10, 2023
@relrelb
relrelb deleted the profiles_completion branch August 10, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndeloof ndeloof ndeloof approved these changes
@glours glours glours approved these changes
@nicksieger nicksieger Awaiting requested review from nicksieger nicksieger is a code owner automatically assigned from docker/compose-maintainers
@StefanScherer StefanScherer Awaiting requested review from StefanScherer StefanScherer is a code owner automatically assigned from docker/compose-maintainers
@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza ulyssessouza is a code owner automatically assigned from docker/compose-maintainers
@laurazard laurazard Awaiting requested review from laurazard laurazard is a code owner automatically assigned from docker/compose-maintainers
+1 more reviewer
@milas milas milas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@milas milas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@relrelb @ndeloof @glours @milas