build: fix missing proxy build args for classic builder#10876
Closed
milas wants to merge 1 commit into
Closed
Conversation
milas
requested review from
StefanScherer,
glours,
laurazard,
ndeloof,
nicksieger and
ulyssessouza
and removed request for
a team
August 3, 2023 18:45
Refactor to use a consistent code path for determining the build args for a service image regardless of whether BuildKit or the classic builder is being used. After recent changes, these code paths had diverged, so the classic builder was missing the proxy variables from the Docker client config. Signed-off-by: Milas Bowman <[email protected]>
milas
force-pushed
the
classic-build-args
branch
from
August 3, 2023 18:51
3d88aa0 to
92111f5
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10876 +/- ##
==========================================
+ Coverage 58.30% 58.36% +0.05%
==========================================
Files 119 119
Lines 10331 10323 -8
==========================================
+ Hits 6024 6025 +1
+ Misses 3710 3701 -9
Partials 597 597
☔ View full report in Codecov by Sentry. |
glours
approved these changes
Aug 3, 2023
ndeloof
approved these changes
Aug 4, 2023
milas
enabled auto-merge (squash)
August 4, 2023 21:05
auto-merge was automatically disabled
August 8, 2023 19:26
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Refactor to use a consistent code path for determining the build args for a service image regardless of whether BuildKit or the classic builder is being used.
After recent changes, these code paths had diverged, so the classic builder was missing the proxy variables from the Docker client config.
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did
