progress: minor correctness fixes#10871
Merged
Merged
Conversation
milas
requested review from
StefanScherer,
glours,
laurazard,
ndeloof,
nicksieger and
ulyssessouza
and removed request for
a team
August 3, 2023 13:20
glours
approved these changes
Aug 3, 2023
ndeloof
approved these changes
Aug 3, 2023
* When waiting for dependencies, `select` on the context as well as the ticker * Write multiple progress events "transactionally" (i.e. hold the lock for the duration to avoid other events being interleaved) * Do not change "finished" steps back to "in progress" to prevent flickering Signed-off-by: Milas Bowman <[email protected]>
milas
force-pushed
the
misc-progress-fixes
branch
from
August 3, 2023 18:51
b11f7ea to
4e31bae
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10871 +/- ##
==========================================
+ Coverage 58.30% 58.35% +0.04%
==========================================
Files 119 119
Lines 10331 10343 +12
==========================================
+ Hits 6024 6036 +12
Misses 3710 3710
Partials 597 597
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
selecton the context as well as the tickerThere are some bigger issues here I want to address, but these are a few quick fixes.
(not mandatory) A picture of a cute animal, if possible in relation to what you did
