Skip to content

trace: instrument compose up at a high-level#10831

Merged
glours merged 1 commit intodocker:v2from
milas:instrument-up
Jul 19, 2023
Merged

trace: instrument compose up at a high-level#10831
glours merged 1 commit intodocker:v2from
milas:instrument-up

Conversation

@milas
Copy link
Copy Markdown
Contributor

@milas milas commented Jul 19, 2023

What I did
Added spans around the following:

  • Image pull
  • Image build
  • Service apply
    • Scale down/up (event)
    • Recreate container (event)
    • Scale up (event)
    • Container start (event)

Related issue

JIRA: https://docker.atlassian.net/browse/ENV-233

(not mandatory) A picture of a cute animal, if possible in relation to what you did
tapir

@milas milas requested a review from a team July 19, 2023 04:08
@milas milas self-assigned this Jul 19, 2023
@milas milas requested review from StefanScherer, glours, laurazard, ndeloof, nicksieger and ulyssessouza and removed request for a team July 19, 2023 04:08
* Image pull
* Image build
* Service apply
  * Scale down/up (event)
  * Recreate container (event)
  * Scale up (event)
  * Container start (event)

Signed-off-by: Milas Bowman <[email protected]>
Copy link
Copy Markdown
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 5159058 into docker:v2 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants