Conversation
milas
requested review from
StefanScherer,
glours,
laurazard,
ndeloof,
nicksieger and
ulyssessouza
and removed request for
a team
https://github.com/docker/buildx/releases/tag/v0.11.0 Several `replace` directives have been removed and dependencies aligned with buildx as needed. Signed-off-by: Milas Bowman <[email protected]>
jedevc
approved these changes
Jun 20, 2023
ndeloof
reviewed
Jun 20, 2023
| return plats, nil | ||
| } | ||
|
|
||
| func convertCacheOptions(in []*pb.CacheOptionsEntry) []bclient.CacheOptionsEntry { |
Contributor
There was a problem hiding this comment.
AFAICT we could use buildflags.ParseCacheEntry
Contributor
Author
There was a problem hiding this comment.
It has to get converted from the buildx protobuf type to the BuildKit client type.
That said, I found the upstream method which I couldn't find earlier for some reason, so I switched to that: https://github.com/docker/buildx/blob/010e4c8d54dcaa5e661ba7bc6adbf26008c96d4c/controller/pb/cache.go
Signed-off-by: Milas Bowman <[email protected]>
glours
approved these changes
Jun 21, 2023
ndeloof
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
https://github.com/docker/buildx/releases/tag/v0.11.0
Several
replacedirectives have been removed and dependencies aligned with buildx as needed.(not mandatory) A picture of a cute animal, if possible in relation to what you did
