trace: refactor root command span reporting#10719
Merged
Conversation
milas
requested review from
StefanScherer,
glours,
laurazard,
ndeloof,
nicksieger and
ulyssessouza
and removed request for
a team
* Move all the initialization code out of `main.go` * Ensure spans are reported when there's an error with the command * Attach the Compose version & active Docker context to the resource instead of the span * Name the root CLI span `cli/<cmd>` for clarity and grab the full subcommand path (e.g. `alpha-viz` instead of just `viz`) Signed-off-by: Milas Bowman <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10719 +/- ##
==========================================
+ Coverage 58.89% 59.00% +0.11%
==========================================
Files 112 113 +1
Lines 9735 9767 +32
==========================================
+ Hits 5733 5763 +30
- Misses 3413 3416 +3
+ Partials 589 588 -1
☔ View full report in Codecov by Sentry. |
glours
approved these changes
Jun 15, 2023
ndeloof
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
main.gocli/<cmd>for clarity and grab the full subcommand path (e.g.alpha-vizinstead of justviz)Related issue
Fixing all the bugs I introduced: 😅
(not mandatory) A picture of a cute animal, if possible in relation to what you did
