otel: fix initialization / error-handling#10717
Merged
Conversation
milas
requested review from
StefanScherer,
glours,
laurazard,
ndeloof,
nicksieger and
ulyssessouza
and removed request for
a team
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10717 +/- ##
==========================================
- Coverage 58.99% 58.94% -0.06%
==========================================
Files 112 112
Lines 9735 9735
==========================================
- Hits 5743 5738 -5
- Misses 3406 3409 +3
- Partials 586 588 +2
☔ View full report in Codecov by Sentry. |
ndeloof
approved these changes
Jun 15, 2023
* If there's no `otel` key (or the value is `null`) in the config, don't return an error * Propagate error from the exporter instead of panicking Signed-off-by: Milas Bowman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
otelkey (or the value isnull) in the config, don't return an error(not mandatory) A picture of a cute animal, if possible in relation to what you did
