Skip to content

escape containerimage.digest attribute in merge.yml GHA worlflow#10691

Merged
glours merged 2 commits intodocker:v2from
glours:fix-dd-workflow-json-parsing
Jun 13, 2023
Merged

escape containerimage.digest attribute in merge.yml GHA worlflow#10691
glours merged 2 commits intodocker:v2from
glours:fix-dd-workflow-json-parsing

Conversation

@glours
Copy link
Copy Markdown
Contributor

@glours glours commented Jun 12, 2023

What I did
Fix the issue to get the containerimage.digest from the bake steps during the Trigger Docker Desktop e2e with edge version step of the desktop-edge-test job

Related issue
N/A

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@glours glours requested a review from crazy-max June 12, 2023 09:52
@glours glours self-assigned this Jun 12, 2023
@crazy-max
Copy link
Copy Markdown
Member

crazy-max commented Jun 12, 2023

You need to specify the output in the bin-image job. Don't think you can access arbitrary step from a dependent job:

bin-image:
runs-on: ubuntu-22.04
outputs:
tags: ${{ steps.meta.outputs.tags }}
steps:

  bin-image:
    runs-on: ubuntu-22.04
    outputs:
      tags: ${{ steps.meta.outputs.tags }}
      digest: ${{ fromJSON(steps.bake.outputs.metadata).image-cross['containerimage.digest'] }}
    steps:

And in

inputs: {
"image-tag": '${{ fromJSON(needs.bin-image.bake.outputs.metadata).image-cross["containerimage.digest"] }}'
}
you would just need:

inputs: {
  "image-tag": '${{ needs.bin-image.outputs.digest }}'
}

@glours glours force-pushed the fix-dd-workflow-json-parsing branch from 034238e to 8741199 Compare June 12, 2023 12:36
Comment thread .github/workflows/merge.yml Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 12, 2023

Codecov Report

Patch coverage: 48.14% and project coverage change: -0.11 ⚠️

Comparison is base (599723f) 58.91% compared to head (7a870e2) 58.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10691      +/-   ##
==========================================
- Coverage   58.91%   58.81%   -0.11%     
==========================================
  Files         111      112       +1     
  Lines        9709     9743      +34     
==========================================
+ Hits         5720     5730      +10     
- Misses       3401     3424      +23     
- Partials      588      589       +1     
Impacted Files Coverage Δ
pkg/progress/quiet.go 0.00% <0.00%> (ø)
pkg/progress/writer.go 61.53% <0.00%> (-2.47%) ⬇️
cmd/compose/compose.go 70.94% <41.66%> (-2.02%) ⬇️
cmd/compose/restart.go 68.42% <60.00%> (-5.78%) ⬇️
cmd/compose/build.go 81.94% <85.71%> (+7.62%) ⬆️
cmd/compose/down.go 79.16% <100.00%> (ø)
cmd/compose/stop.go 78.12% <100.00%> (ø)
cmd/compose/up.go 71.33% <100.00%> (+1.33%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glours glours force-pushed the fix-dd-workflow-json-parsing branch from 8741199 to 04062f2 Compare June 12, 2023 12:52
@glours glours marked this pull request as ready for review June 12, 2023 12:52
@milas milas changed the title escape containerimage.digest attribut in merge.yml GHA worlflow escape containerimage.digest attribute in merge.yml GHA worlflow Jun 12, 2023
Copy link
Copy Markdown
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Comment thread .github/workflows/merge.yml Outdated
@glours glours force-pushed the fix-dd-workflow-json-parsing branch from 5d68517 to a17848b Compare June 12, 2023 14:34
glours and others added 2 commits June 12, 2023 16:54
@glours glours force-pushed the fix-dd-workflow-json-parsing branch from a17848b to 7a870e2 Compare June 12, 2023 14:54
@glours glours merged commit 08e6bfc into docker:v2 Jun 13, 2023
@glours glours deleted the fix-dd-workflow-json-parsing branch June 30, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants