Do not set a default timeout of 10 seconds when restarting / stopping…#10672
Merged
Do not set a default timeout of 10 seconds when restarting / stopping…#10672
Conversation
ndeloof
approved these changes
Jun 8, 2023
Contributor
|
for legal reasons we require commits to be signed-off. Please amend your commit and force push your branch |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10672 +/- ##
==========================================
- Coverage 58.91% 58.87% -0.05%
==========================================
Files 111 111
Lines 9709 9716 +7
==========================================
Hits 5720 5720
- Misses 3401 3407 +6
- Partials 588 589 +1
☔ View full report in Codecov by Sentry. |
robbert-ef
force-pushed
the
10670-no_default_timeout
branch
from
41b347d to
b384063
Compare
Contributor
Author
done |
robbert-ef
force-pushed
the
10670-no_default_timeout
branch
from
b384063 to
ce63150
Compare
… but use the container StopTimeout (defaults to 10 seconds) Also fixed custom timeout not used when invoking `up` Signed-off-by: Robbert Segeren <[email protected]>
robbert-ef
force-pushed
the
10670-no_default_timeout
branch
from
ce63150 to
d035d2b
Compare
ndeloof
approved these changes
Jun 12, 2023
ndeloof
requested review from
a team,
StefanScherer,
glours,
laurazard,
milas,
nicksieger and
ulyssessouza
and removed request for
a team
glours
approved these changes
Jun 12, 2023
milas
approved these changes
Jun 12, 2023
Contributor
milas
left a comment
milas
left a comment
There was a problem hiding this comment.
Thanks for the PR, nice improvement! ✨
| Short: "Create and start containers", | ||
| PreRunE: AdaptCmd(func(ctx context.Context, cmd *cobra.Command, args []string) error { | ||
| create.pullChanged = cmd.Flags().Changed("pull") | ||
| create.timeChanged = cmd.Flags().Changed("waitTimeout") |
Contributor
There was a problem hiding this comment.
sometime goland "rename" feature tries to be too clever...
This was referenced Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… but use the container StopTimeout (defaults to 10 seconds)
Also fixed custom timeout not used when invoking
upWhat I did
The default timeout value of 10 seconds when using stop / restart was removed.
This now defaults to the container
StopTimeoutwhich can be set usingstop_grace_periodand defaults to 10 seconds.Also fixed custom timeout value not being used when calling
docker compose upRelated issue
fixes #10670
(not mandatory) A picture of a cute animal, if possible in relation to what you did
