Skip to content

ci: upgrade to Go 1.20.5 and Moby v24.x#10662

Merged
glours merged 1 commit intodocker:v2from
milas:bump-deps
Jun 8, 2023
Merged

ci: upgrade to Go 1.20.5 and Moby v24.x#10662
glours merged 1 commit intodocker:v2from
milas:bump-deps

Conversation

@milas
Copy link
Copy Markdown
Contributor

@milas milas commented Jun 6, 2023

What I did
Upgrade to Go 1.20.5 and Moby v24.x.

There's a few tweaks needed to keep things compiling and linter passing, but nothing major.

(not mandatory) A picture of a cute animal, if possible in relation to what you did
banana slug

@milas milas added the dependencies Pull requests that update a dependency file label Jun 6, 2023
@milas milas requested a review from a team June 6, 2023 21:01
@milas milas self-assigned this Jun 6, 2023
@milas milas requested review from StefanScherer, glours, laurazard, ndeloof, nicksieger and ulyssessouza and removed request for a team June 6, 2023 21:01
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2023

Codecov Report

Patch coverage: 54.54% and project coverage change: +0.12 🎉

Comparison is base (f8b6459) 59.65% compared to head (37850f7) 59.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10662      +/-   ##
==========================================
+ Coverage   59.65%   59.77%   +0.12%     
==========================================
  Files         107      107              
  Lines        9485     9490       +5     
==========================================
+ Hits         5658     5673      +15     
+ Misses       3242     3235       -7     
+ Partials      585      582       -3     
Impacted Files Coverage Δ
pkg/api/dryrunclient.go 0.00% <0.00%> (ø)
pkg/compose/build_classic.go 52.25% <50.00%> (ø)
pkg/compose/compose.go 61.58% <100.00%> (+0.66%) ⬆️
pkg/compose/cp.go 60.60% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndeloof
Copy link
Copy Markdown
Contributor

ndeloof commented Jun 7, 2023

need to regenerate mocks after API upgrade

Copy link
Copy Markdown
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 955784c into docker:v2 Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants