Merged
Conversation
Requires some changes for depguard config Signed-off-by: Milas Bowman <[email protected]>
milas
requested review from
StefanScherer,
glours,
laurazard,
ndeloof,
nicksieger and
ulyssessouza
and removed request for
a team
ndeloof
approved these changes
Jun 6, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10659 +/- ##
===========================================
- Coverage 59.71% 19.38% -40.34%
===========================================
Files 107 104 -3
Lines 9481 9388 -93
===========================================
- Hits 5662 1820 -3842
- Misses 3236 7372 +4136
+ Partials 583 196 -387 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Upgrade golangci-lint to v1.53.2. (Mostly because I occasionally run my local install from Homebrew and it was annoying me that it was giving false positives due to config file format changes.)
Related issue
n/a
(not mandatory) A picture of a cute animal, if possible in relation to what you did
