don't skip compose used as project name#10657
Merged
Conversation
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
requested review from
a team,
StefanScherer,
glours,
milas,
nicksieger and
ulyssessouza
and removed request for
a team
ndeloof
force-pushed
the
compose_project_name
branch
from
be3a4ef to
60fe974
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10657 +/- ##
===========================================
- Coverage 59.20% 19.46% -39.74%
===========================================
Files 107 104 -3
Lines 9466 9384 -82
===========================================
- Hits 5604 1827 -3777
- Misses 3281 7364 +4083
+ Partials 581 193 -388
☔ View full report in Codecov by Sentry. |
laurazard
approved these changes
Jun 6, 2023
Member
laurazard
left a comment
laurazard
left a comment
There was a problem hiding this comment.
LGTM from me (although yeah, also curious about that code from the compatibility flag)
milas
approved these changes
Jun 6, 2023
Contributor
milas
left a comment
milas
left a comment
There was a problem hiding this comment.
LGTM, I'm guessing this was supposed to be if arg[0] == compose.PluginName originally? But clearly it's not doing anything useful so I am good with eliminating it
glours
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
fix support for converting
docker-compose --project-name composeinto a compose v2 command (docker <space> compose)Tried to understand the fix in #8985 to skip
composeargument but doesn't make any sense to me after 18 months. This code is only used if command isdocker-compose ..but not when used as a CLI plugin withdocker compose ..., maybe this wasn't the case earlier? @ulyssessouza do you remember?Related issue
fixes #10647
(not mandatory) A picture of a cute animal, if possible in relation to what you did