create directory in container using mkdir -p#10652
Merged
Conversation
ndeloof
force-pushed
the
watch_mkdir
branch
2 times, most recently
from
f797f00 to
fa8e5af
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10652 +/- ##
===========================================
- Coverage 59.75% 19.39% -40.36%
===========================================
Files 107 104 -3
Lines 9481 9411 -70
===========================================
- Hits 5665 1825 -3840
- Misses 3234 7391 +4157
+ Partials 582 195 -387
☔ View full report in Codecov by Sentry. |
ndeloof
requested review from
a team,
StefanScherer,
glours,
milas,
nicksieger and
ulyssessouza
and removed request for
a team
milas
approved these changes
Jun 6, 2023
Contributor
milas
left a comment
milas
left a comment
There was a problem hiding this comment.
LGTM, kind of annoying that there's no option in the Engine API to create the path if necessary (both because this means an extra API call & because it'll necessitate having a working mkdir in the image, though I'm fine with that assumption/limitation tbh 🙃)
| _, err := s.Exec(ctx, project.Name, api.RunOptions{ | ||
| Service: opt.Service, | ||
| Command: []string{"rm", "-rf", opt.ContainerPath}, | ||
| Index: 1, |
Contributor
There was a problem hiding this comment.
Suggested change
| Index: 1, | |
| Index: i, |
Signed-off-by: Nicolas De Loof <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
on fsevent related to a directory,
docker exec mkdir -pto ensure target directory exists as we later rundocker cpotherwise PutContainerArchive will fail with 404 as documented on https://docs.docker.com/engine/api/v1.42/#tag/Container/operation/PutContainerArchiveRelated issue
fixes #10644
https://docker.atlassian.net/browse/ENV-204
(not mandatory) A picture of a cute animal, if possible in relation to what you did