Skip to content

add Windows drive prefix to temp dir usage in the doc generation task#10637

Merged
ndeloof merged 1 commit intodocker:v2from
glours:fix-doc-generation-windows
May 31, 2023
Merged

add Windows drive prefix to temp dir usage in the doc generation task#10637
ndeloof merged 1 commit intodocker:v2from
glours:fix-doc-generation-windows

Conversation

@glours
Copy link
Copy Markdown
Contributor

@glours glours commented May 31, 2023

What I did
Add Windows drive prefix to temp directory when executing a shell command like cp or rm

At least Makefile will work with Git Bash

Related issue
N/A

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@glours glours requested review from aevesdocker, milas and ndeloof May 31, 2023 07:34
@glours glours marked this pull request as ready for review May 31, 2023 07:35
@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (b0a35cc) 59.40% compared to head (6d2c377) 59.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10637      +/-   ##
==========================================
+ Coverage   59.40%   59.45%   +0.05%     
==========================================
  Files         107      107              
  Lines        9395     9395              
==========================================
+ Hits         5581     5586       +5     
+ Misses       3240     3236       -4     
+ Partials      574      573       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndeloof ndeloof closed this May 31, 2023
@ndeloof ndeloof reopened this May 31, 2023
@ndeloof ndeloof merged commit 83ad5e9 into docker:v2 May 31, 2023
@glours glours deleted the fix-doc-generation-windows branch June 30, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants