Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10633 +/- ##
==========================================
+ Coverage 59.40% 59.51% +0.10%
==========================================
Files 107 107
Lines 9395 9403 +8
==========================================
+ Hits 5581 5596 +15
+ Misses 3240 3234 -6
+ Partials 574 573 -1
☔ View full report in Codecov by Sentry. |
Signed-off-by: Nicolas De Loof <[email protected]>
|
Would this fix allow for |
|
@g0t4 |
|
@ndeloof Hello sir, is this still true? If a process is launched with docker compose up - there is no way for my image to be sent the shutdown signal? Are there any ways to achieve it? |
|
Ctrl+C or |
What I did
as compose run a container, forward signals to container the same way
docker rundoeswe have to because
RunStartonly doest it for container without a TTY (https://github.com/docker/cli/blob/master/cli/command/container/start.go#L91)As container is ran interactive from a terminal (
--tty=true),RunStartusessetRawTerminaland doing so user to hiCtrl+Cjust directly send those keys to target process, notcomposecommand itself.But when signal is sent to compose by a
killcommand it has to handle this and forward signal explicitly, just likeRunStartdoes when container has no TTY.Related issue
fixes #10586
(not mandatory) A picture of a cute animal, if possible in relation to what you did