Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10625 +/- ##
==========================================
+ Coverage 58.91% 59.78% +0.86%
==========================================
Files 111 107 -4
Lines 9709 9481 -228
==========================================
- Hits 5720 5668 -52
+ Misses 3401 3232 -169
+ Partials 588 581 -7 ☔ View full report in Codecov by Sentry. |
glours
force-pushed
the
compose-edge-desktop-integration
branch
2 times, most recently
from
ed2cb57 to
ef8d233
Compare
mat007
reviewed
Jun 2, 2023
| name: Trigger Docker Desktop e2e with edge version | ||
| uses: actions/github-script@v6 | ||
| with: | ||
| github-token: ${{ secrets.DOCKERPUBLICBOT_WRITE_PAT }} |
Member
There was a problem hiding this comment.
That’s a token for Docker Hub, isn’t it? I’m not sure it’s going to help there.
Contributor
Author
There was a problem hiding this comment.
Yep, that's why this PR is still a draft, I also need to update the way I'll get the image tag to pass to the workflow
glours
force-pushed
the
compose-edge-desktop-integration
branch
2 times, most recently
from
2a84a3b to
0155002
Compare
glours
force-pushed
the
compose-edge-desktop-integration
branch
from
0155002 to
4f97c84
Compare
ndeloof
approved these changes
Jun 2, 2023
…ge version Signed-off-by: Guillaume Lours <[email protected]>
glours
force-pushed
the
compose-edge-desktop-integration
branch
from
4f97c84 to
ec31d3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add a GitHub action job to trigger Docker Desktop e2e tests with the latest edge version of Compose to early detect integration issue.
Related issue
https://docker.atlassian.net/browse/ENV-120
(not mandatory) A picture of a cute animal, if possible in relation to what you did
