fix compose -p x logs -f detect new services started after command#10622
Merged
fix compose -p x logs -f detect new services started after command#10622
compose -p x logs -f detect new services started after command#10622Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10622 +/- ##
==========================================
+ Coverage 59.55% 60.11% +0.55%
==========================================
Files 107 107
Lines 9438 9450 +12
==========================================
+ Hits 5621 5681 +60
+ Misses 3241 3193 -48
Partials 576 576
☔ View full report in Codecov by Sentry. |
ndeloof
changed the title
compose -p x logs -f detect new services started after command
Contributor
Author
|
e2e test is failing due to #10621 : scale up recreate container, which takes 10s |
ndeloof
requested review from
a team,
StefanScherer,
glours,
laurazard,
milas,
nicksieger and
ulyssessouza
and removed request for
a team
…logs` with no explicit services Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
milas
approved these changes
May 31, 2023
Contributor
milas
left a comment
milas
left a comment
There was a problem hiding this comment.
LGTM!
I did a bunch of combinations of up & down across different terminals, targeting specific services/adjusting scale/etc with an open compose -p $NAME logs -f session and everything worked great ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when we run
compose --project-name logswe SHOULD detect new services being started after the initial model has been built from actual ressources. For this purpose,createevents` adds container to the watched listadded an e2e test to check this behaves as expected
Related issue
fixes #10618
(not mandatory) A picture of a cute animal, if possible in relation to what you did