compute service hash with a default DeployConfig#10621
Merged
Conversation
ndeloof
requested review from
a team,
StefanScherer,
glours,
laurazard,
milas,
nicksieger and
ulyssessouza
and removed request for
a team
Contributor
Author
|
While this would be a significant effort, I wonder we should stop using service hash, but use |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10621 +/- ##
==========================================
- Coverage 59.57% 59.55% -0.02%
==========================================
Files 107 107
Lines 9437 9438 +1
==========================================
- Hits 5622 5621 -1
- Misses 3239 3241 +2
Partials 576 576
☔ View full report in Codecov by Sentry. |
Contributor
This is something we should consider, I agree |
ndeloof
force-pushed
the
scale_recreate
branch
2 times, most recently
from
95fa56f to
95d5a04
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
glours
approved these changes
May 26, 2023
Contributor
glours
left a comment
glours
left a comment
There was a problem hiding this comment.
Much better with a e2e test 😉🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
as we compute service hash to compare actual vs expected state, always consider a default
DeployConfigas passing--scale service=Nwill create one, even if the compose.yaml config doesn't define such a sectionhow to test:
container test-1 MUST not be re-created
with this PR: