Conversation
milas
requested review from
StefanScherer,
glours,
laurazard,
ndeloof,
nicksieger and
ulyssessouza
and removed request for
a team
glours
approved these changes
May 24, 2023
ndeloof
reviewed
May 24, 2023
Member
|
cfssl is the worst; it had a TON of dependencies; I managed to get rid of a bunch of them, but don't think they did a new release still; https://github.com/cloudflare/cfssl/pulls?q=is%3Apr+author%3AthaJeztah |
Write the warning using `logrus.Warn`. The function being used was coming from `cfssl`'s log package, which was presumably the result of auto-import being _slightly_ too aggressive. (Note: `cfssl` is still an indirect dependency after this.) Signed-off-by: Milas Bowman <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10614 +/- ##
==========================================
+ Coverage 59.45% 59.55% +0.10%
==========================================
Files 107 107
Lines 9364 9437 +73
==========================================
+ Hits 5567 5620 +53
- Misses 3220 3241 +21
+ Partials 577 576 -1
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Just write the warning to the passed in writer. The function being used was coming from
cfssl's log package, which was presumably the result of auto-import being slightly too aggressive.(Note:
cfsslis still an indirect dependency after this.)Related issue
n/a
(not mandatory) A picture of a cute animal, if possible in relation to what you did
