Skip to content

fix support for project name set by COMPOSE_PROJECT_NAME env var#10597

Merged
glours merged 1 commit intodocker:v2from
ndeloof:ComposeProjectName
May 22, 2023
Merged

fix support for project name set by COMPOSE_PROJECT_NAME env var#10597
glours merged 1 commit intodocker:v2from
ndeloof:ComposeProjectName

Conversation

@ndeloof
Copy link
Copy Markdown
Contributor

@ndeloof ndeloof commented May 22, 2023

What I did

Related issue
close #10593

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@ndeloof ndeloof requested review from a team, StefanScherer, glours, laurazard, milas, nicksieger and ulyssessouza and removed request for a team May 22, 2023 17:16
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.14 ⚠️

Comparison is base (34bd41c) 59.56% compared to head (daa6bec) 59.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10597      +/-   ##
==========================================
- Coverage   59.56%   59.42%   -0.14%     
==========================================
  Files         107      107              
  Lines        9359     9359              
==========================================
- Hits         5575     5562      -13     
- Misses       3210     3220      +10     
- Partials      574      577       +3     
Impacted Files Coverage Δ
cmd/compose/compose.go 72.96% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glours glours merged commit 544b579 into docker:v2 May 22, 2023
@ndeloof ndeloof deleted the ComposeProjectName branch December 20, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] COMPOSE_PROJECT_NAME broken in docker compose exec since 2.18

2 participants