Skip to content

only check the platform of cached image if image found#10575

Merged
ndeloof merged 1 commit intodocker:v2from
glours:fix-build-issue-local-cache
May 17, 2023
Merged

only check the platform of cached image if image found#10575
ndeloof merged 1 commit intodocker:v2from
glours:fix-build-issue-local-cache

Conversation

@glours
Copy link
Copy Markdown
Contributor

@glours glours commented May 16, 2023

What I did
Fix build issue introduced in Compose v2.18.0 when checking local cached image platform (see #10546)

Related issue
Fixes #10574

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@glours glours requested review from milas and ndeloof and removed request for ndeloof May 16, 2023 21:49
@glours glours self-assigned this May 16, 2023
@glours glours changed the title only check the platform of cache image if image found only check the platform of cached image if image found May 16, 2023
@glours glours force-pushed the fix-build-issue-local-cache branch from b94bec8 to f951d6a Compare May 16, 2023 21:57
Copy link
Copy Markdown
Contributor

@ndeloof ndeloof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
minor readability suggestion

Comment thread pkg/compose/build.go Outdated
@glours glours force-pushed the fix-build-issue-local-cache branch from f951d6a to ff93299 Compare May 17, 2023 05:54
@ndeloof ndeloof enabled auto-merge (rebase) May 17, 2023 05:57
@ndeloof ndeloof merged commit cd0fc21 into docker:v2 May 17, 2023
@glours glours deleted the fix-build-issue-local-cache branch June 30, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] New 2.18 releases fails to build images when runnig up --build

2 participants