sort containers by creation date to scale down the older ones#10571
Merged
sort containers by creation date to scale down the older ones#10571
Conversation
Signed-off-by: Nicolas De Loof <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## v2 #10571 +/- ##
=======================================
Coverage 59.49% 59.49%
=======================================
Files 107 107
Lines 9356 9359 +3
=======================================
+ Hits 5566 5568 +2
Misses 3214 3214
- Partials 576 577 +1
☔ View full report in Codecov by Sentry. |
ndeloof
requested review from
a team,
StefanScherer,
glours,
laurazard,
milas,
nicksieger and
ulyssessouza
and removed request for
a team
milas
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
sort service containers by creation date, so that scaling down will remove the older ones. This makes "down scale" more deterministic.
This allows to better support no-downtime container replacement by running:
Related issue
fixes #10569
(not mandatory) A picture of a cute animal, if possible in relation to what you did