detect active endpoint trying to remove network and skip with a warning#10555
Merged
detect active endpoint trying to remove network and skip with a warning#10555
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10555 +/- ##
==========================================
+ Coverage 59.66% 59.67% +0.01%
==========================================
Files 107 107
Lines 9324 9337 +13
==========================================
+ Hits 5563 5572 +9
- Misses 3190 3192 +2
- Partials 571 573 +2
☔ View full report in Codecov by Sentry. |
ndeloof
force-pushed
the
network_removal_in_use
branch
from
3862db0 to
4173af7
Compare
ndeloof
requested review from
a team,
StefanScherer,
glours,
laurazard,
milas,
nicksieger and
ulyssessouza
and removed request for
a team
ndeloof
force-pushed
the
network_removal_in_use
branch
from
4173af7 to
b33f53a
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
network_removal_in_use
branch
from
b33f53a to
0a03604
Compare
milas
approved these changes
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Running
compose downwith a partial project, attempt to remove network fails witherror while removing network: network xxx has active endpoints. With proposed changes, compose list active endpoints and skip network removal with a warning.downcommand then complete successfully.see #10295