Documentation: Include notes on mapping ports#104
Conversation
|
I wonder if it'd be better to just have port and volume entries in strings everywhere in the docs, to encourage people to do it all the time. Otherwise it's not clear from just looking at the YAML why some are and some aren't, and if/when you should do it yourself. As we all know, hardly anyone reads the docs in the first place. |
|
(to be clear: we absolutely should still include your note.) |
|
@aanand I wasn't sure whether to update all of the ports in the documentation. Personally I prefer the consistency of all the port mappings being strings and if that is the agreement then I'll update it. |
|
👍 quotes everywhere with a short note explaining that they need to be in quotes. |
When mapping ports as strings there is an issue with the way YAML parses numbers in the format "xx:yy" where yy is less than 60 - this issue is now included in the documentation. This fixes docker#103
|
I have updated all the yaml files I found in the documentation to include this change. The reason is explained in the readme as well as the doc page for the yaml. |
Documentation: Include notes on mapping ports
|
Thanks @Gazler! |
Documentation: Include notes on mapping ports Signed-off-by: Yuval Kohavi <[email protected]>
Reject duplicate keys on the notifier
3 participants
When mapping ports as strings there is an issue with the way YAML parses
numbers in the format "xx:yy" where yy is less than 60 - this issue is
now included in the documentation.
This fixes #103